Talk:GitHub Pull Requests

From Gentoo Wiki
(Redirected from Talk:Github Pull Requests)
Jump to: navigation, search
Note
This is a talk page. Please add newer comments below older ones, and sign your comments using four tildes (~~~~). When adding a new section (at the bottom of the page), please mark it as "open for discussion" by using {{talk|open}} so it will show up in the list of open discussions.

git+ssh://

Talk status
This discussion is still ongoing as of 02 December 2017.

Some link for an explanation (maybe in a subarticle) about authenticity of host would be nice:

user $git clone -o upstream git+ssh://git@git.gentoo.org/repo/gentoo.git
Cloning into 'gentoo'...
The authenticity of host 'git.gentoo.org (148.251.78.52)' can't be established.
ECDSA key fingerprint is SHA256:lDtZUg9Kg55tWetA0Yf+eWAZdq/SvKPIgs65EPQ98ao.
Are you sure you want to continue connecting (yes/no)? y

Please type 'yes' or 'no': yes
Warning: Permanently added 'git.gentoo.org,148.251.78.52' (ECDSA) to the list of known hosts.
Authentication failed.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
--Charles17 (talk) 09:06, 2 December 2017 (UTC)
According to this forum topic, the git+ssh:// protocol can be used only by Gentoo developers, not by end users. --Charles17 (talk) 17:02, 4 December 2017 (UTC)
Yes and no. This picture explains it better. Only the developer with write access to the tree writes to git.gentoo.org. The user may do what he/she wants on the github fork. https://wiki.gentoo.org/wiki/File:Github_pull_request.png Please comment on the new picture. We can improve it and then cut it into sections for this article. I think it fits better than the current illustration. --Jonas Stein (talk) 23:40, 13 December 2017 (UTC)
Thanks for the nice picture. My question was related to this version where you said User configures the local repository using that certain command. git clone -o upstream git+ssh://git@git.gentoo.org/repo/gentoo.git. Did you mean to say ordinary users could use git+ssh://github.com but not git+ssh://git.gentoo.org?--Charles17 (talk) 07:08, 14 December 2017 (UTC)
You can use git+ssh on your fork of the gentoo/gentoo repository on GitHub, but usually not on the gentoo/gentoo repository directly. Waebbl (talk) 12:45, 14 December 2017 (UTC)
In my opinion the new picture illustrates the process very well. I would propose to either put Alice to the right of the picture, or split it into two pictures, one for each role. Waebbl (talk) 12:45, 14 December 2017 (UTC)